Skip to content
This repository was archived by the owner on Jul 4, 2021. It is now read-only.

feat: add default lang and global scope plugin options for SFC i18n custom block #109

Merged
merged 11 commits into from
Jul 1, 2021

Conversation

userquin
Copy link
Member

closes #108

Also added .idea/ directory to be excluded on .gitignore (intellj/webstorm stuff).

@userquin
Copy link
Member Author

Maybe options names can be others...

@kazupon
Copy link
Member

kazupon commented Jun 30, 2021

@userquin
Thank you for your PR!

Sorry, currently, I'm a little busy with my day job. 🙇
I'll try to check your PR later. 😉

@userquin
Copy link
Member Author

userquin commented Jun 30, 2021

I need to add docs for these 2 new options (but first I'll wait for your feedback, once ok I can add docs) and also on the site (at least here: https://vue-i18n.intlify.dev/guide/advanced/sfc.html#bundling-with-vite, and here https://vue-i18n.intlify.dev/guide/advanced/sfc.html#bundling-with-rollup (for webpack I need to review options), but it is is another repo).

@kazupon
Copy link
Member

kazupon commented Jun 30, 2021

@userquin
I've just checked your PR!

Could you add these options docs to README please?

@userquin
Copy link
Member Author

@userquin
I've just checked your PR!

Could you add these options docs to README please?

give me a few minutes

docs: add docs for `defaultSFCLang` and `globalSFCScope`
@userquin
Copy link
Member Author

userquin commented Jun 30, 2021

I only add it on options section (with an example), do you want I add something on i18n custom block section?

@userquin
Copy link
Member Author

Don't merge yet.

I'll add a warning, since globalSFCScope cannot be disable once configured (global attribute has no values).

For defaultSFCLang I need to add a hint: it can be overriden using i18n lang custom block attribute.

@userquin
Copy link
Member Author

Done

@kazupon
Copy link
Member

kazupon commented Jul 1, 2021

@userquin
That's great work!
Thanks!

@kazupon kazupon added the Type: Feature Includes new features label Jul 1, 2021
@kazupon kazupon merged commit 8ee092b into intlify:master Jul 1, 2021
@userquin userquin deleted the feat/add-lang-and-scope-options branch July 1, 2021 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature Includes new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add default lang and scope on plugin configuration for i18n custom block
2 participants