Improved depth estimation of mono features #1460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameters:
OdomF2M/BundleUpdateFeatureMapOnAllFrames
: Update 3D local feature map on every frame with bundle adjustment. Recommended ifVis/DepthAsMask=false
andMem/UseOdomFeatures=true
so that features without depth are better triangulated on every frame (not only on keyframes). If disabled, the feature map is updated only when a new keyframe is added (legacy approach).OdomF2M/FloorThreshold
: Only track features in 3D feature map that are over this threshold (height in base frame). Can be useful to ignore reflections on the floor. 0 means disabled.OdomF2M/InitDepthFactor
: Depth factor used to initialize depth of features without depth. Depth = Factor * fx.TODO: Re-run vslam benchmark datasets with and without
OdomF2M/BundleUpdateFeatureMapOnAllFrames
to see if it doesn't affect too negatively the results. Ideally, we would wantOdomF2M/BundleUpdateFeatureMapOnAllFrames
to be true by default so that depth of mono features can be correctly estimated all the time.