-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multithreaded load / save per entry #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. still some issues.
But you got the locks in the right places which is important
Can we do this in a way that maintains compatibility with Julia 1.0?
Does Compat.jl have support for making @spawn
into @async
or some such?
I'll take a look at Julia 1.0 compat a bit later |
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 96.00% 96.15% +0.15%
==========================================
Files 6 6
Lines 150 156 +6
==========================================
+ Hits 144 150 +6
Misses 6 6 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
can you bump the minor version so we can tag a release?
Thanks! |
Loading 10GB of data on a laptop with 4 cores goes from
to
Saving is probably even more interesting, that took 6mins, I can check if it goes to 1.5 minutes with this PR