Updates AsyncHandler test case to accommodate fix added in v1.8.0-beta1
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 4, 2022 17:42
Just need to write a test case for serializing and deserializing to ensure that the behaviour doesn't change again
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
+ Coverage 98.26% 98.55% +0.28%
==========================================
Files 14 14
Lines 404 414 +10
==========================================
+ Hits 397 408 +11
+ Misses 7 6 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was a test case for where serializing io with an AsyncHandler caused an exception. Memento was changed to accommodate this fix here.
With the changes made to v
1.8.0-beta1(the addition of support AbstractLock and GenericCondition), this case no longer needs to be covered.Fixes: #184