-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport stdlib mod nothing #190
Conversation
Codecov Report
@@ Coverage Diff @@
## backport-v1.2.0 #190 +/- ##
===================================================
- Coverage 98.23% 97.98% -0.25%
===================================================
Files 13 13
Lines 396 397 +1
===================================================
Hits 389 389
- Misses 7 8 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I think typically the Julia community would name the branch |
FWIW, we usually |
How do we register this new 1.2.1 version? I had a guess and triggered the TagBot actions on the backport branch (https://github.com/invenia/Memento.jl/actions/runs/3242019552), but the output says |
@arnaudh you do so through a comment, like this: c03bd20#commitcomment-86699867 |
@JuliaRegistrator register |
Error while trying to register: Register Failed |
@JuliaRegistrator register |
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
Thanks, now I know (and have made my membership to Invenia public so I can do it next time). I see @BaileyBox did it for this MR, thanks! e398beb#commitcomment-86609403 |
@arnaudh no, I did it for this PR, in the comment I linked above. Bailey's was for a different PR. |
Backport of #185 for the 1.2.0 branch (which I created from the
v1.2.0
tag for the occasion - let me know if that's not the right process).This is so that CloudWatchLogs can pull in the fix (there Memento is upper-bounded to 1.2 due to date representation differences).