Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom option for the HtmlElement type #106

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

Freymaurer
Copy link
Contributor

  • Added suggested changes from issue HtmlElement.Custom #104 .
  • Added unit tests based of existing tests and style
  • run tests ✅

@baronfel
Copy link
Contributor

This seems good to me 👍. @Krzysztof-Cieslak what's it take to do a release in this repo? Tag push?

@baronfel baronfel merged commit 75d0fde into ionide:master Apr 14, 2022
@Freymaurer Freymaurer deleted the HtmlElement_custom-issue104 branch April 19, 2022 08:16
@Freymaurer
Copy link
Contributor Author

Would really love to see a release as soon as possible 👍

@Freymaurer
Copy link
Contributor Author

Are there any news for a release?

@Freymaurer
Copy link
Contributor Author

Sorry for the spam, just really need at least an timeframe @baronfel .

@baronfel
Copy link
Contributor

sorry, just push 0.14.1, which includes this change.

@Freymaurer
Copy link
Contributor Author

@baronfel sry it's me again. As far as i understand it, there is no nuget package for v0.14.0, so i cannot actually use the new version 😢

@baronfel
Copy link
Contributor

baronfel commented May 5, 2022

image

Looks like we have a bug in the release script - it reported success here but didn't push anything.

@baronfel
Copy link
Contributor

baronfel commented May 5, 2022

Fixed the bug and manually uploaded 0.14.1 to NuGet, should be done indexing in a few minutes:

image

@Freymaurer
Copy link
Contributor Author

Freymaurer commented May 5, 2022

Thanks a lot!

@Freymaurer
Copy link
Contributor Author

Hey and me again 😅 I use dotnet local tools and updated my dotnet-tools.json to the new version. Used dotnet tool restore (this time no error, so package was found), but the function, i need, is still not accessible. I checked the version dotnet fornax version which returned 0.13.1 for me. Not sure if the Fornax.Core.dll gets updated via dotnet tools, so i created a new fornax project somewhere else (fornax new) and it worked there. I copied the dll's to my prev. project and it works now, thanks!

Just wanted to tell you about it, as i don't know if the "updating" of fornax is expected to work or not.

And one more thing, when you intilialize a new fornax project, there is currently an error, introduced in my PR.

In layout.fsx

body [] [
          nav [Class "navbar"] [
            div [Class "container"] [
              div [Class "navbar-brand"] [
                a [Class "navbar-item"; Href "/"] [
                  img [Src "/images/bulma.png"; Alt "Logo"]
                ]
                // Custom is not recognized as HtmlProperties, but as my freshly introduced type.
                span [Class "navbar-burger burger"; HtmlProperties.Custom ("data-target", "navbarMenu")] [
                  span [] []
                  span [] []
                  span [] []
                ]
              ]
              div [Id "navbarMenu"; Class "navbar-menu"] menuEntries
            ]
          ]
          yield! bodyCnt
          custom "" [] []
        ]

No matter what, thanks for all your effort, highly appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants