-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom option for the HtmlElement type #106
Add custom option for the HtmlElement type #106
Conversation
Freymaurer
commented
Apr 2, 2022
- Added suggested changes from issue HtmlElement.Custom #104 .
- Added unit tests based of existing tests and style
- run tests ✅
This seems good to me 👍. @Krzysztof-Cieslak what's it take to do a release in this repo? Tag push? |
Would really love to see a release as soon as possible 👍 |
Are there any news for a release? |
Sorry for the spam, just really need at least an timeframe @baronfel . |
sorry, just push 0.14.1, which includes this change. |
@baronfel sry it's me again. As far as i understand it, there is no nuget package for v0.14.0, so i cannot actually use the new version 😢 |
Thanks a lot! |
Hey and me again 😅 I use dotnet local tools and updated my Just wanted to tell you about it, as i don't know if the "updating" of fornax is expected to work or not. And one more thing, when you intilialize a new fornax project, there is currently an error, introduced in my PR. In body [] [
nav [Class "navbar"] [
div [Class "container"] [
div [Class "navbar-brand"] [
a [Class "navbar-item"; Href "/"] [
img [Src "/images/bulma.png"; Alt "Logo"]
]
// Custom is not recognized as HtmlProperties, but as my freshly introduced type.
span [Class "navbar-burger burger"; HtmlProperties.Custom ("data-target", "navbarMenu")] [
span [] []
span [] []
span [] []
]
]
div [Id "navbarMenu"; Class "navbar-menu"] menuEntries
]
]
yield! bodyCnt
custom "" [] []
] No matter what, thanks for all your effort, highly appreciate it. |