Feature Request: High-level API for reading and writing large encrypted files #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of array capacity with array count to avoid out of bounds access
…c updates to harden saftey checks and return values for CipherInputStream and CipherOutputStream
…nsion writeBytes() for OutputStreamLike
|
Thanks for taking the time to suggest this and putting in all the effort to get it working. However, I am not sure this is a good fit for this repository. Specifically, the goal of this library is provide a Swift wrapper around CommonCrypto, not to add additional functionality. I would recommend creating your own repo that includes this library as a dependency. All that being said, I'll try to take some time to take a look at your code over the weekend and let you know if I spot any issues. |
|
Thanks for the feedback! That totally makes sense - will work on getting this into it's own repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new class
AESEncryptedFilewhich takes a file path + password, and produces anInputStreamto read from or anOutputStreamto write to. Written data will be encrypted before it hits the disk, and the file can be decrypted/read back from disk when given the same password.The intent here is to make a plug-and-play solution similar to the AndroidX EncryptedFile API for people who are novices with crypto (like myself).
I'm new-ish to swift and the CommonCrypto library, so any suggestions here are very much welcome