Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix ipfs-companion import error #60

Merged
merged 2 commits into from
Jan 18, 2023
Merged

chore: fix ipfs-companion import error #60

merged 2 commits into from
Jan 18, 2023

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jan 18, 2023 •
edited
Loading

@SgtPooki SgtPooki mentioned this pull request Jan 18, 2023
Merged
6 tasks
whizzzkid
whizzzkid approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the web analytics sdk looks like cjs, which may not be importable by node as such, if this works it works, but this should be reported to countly, maybe they wanna ship an ESM too.

CI on companion was flaky, re-run fixed it.

whizzzkid
whizzzkid reviewed Jan 18, 2023
View reviewed changes
src/MetricsProvider.ts

constructor ({ autoTrack = true, url = COUNTLY_API_URL, appKey }: MetricsProviderConstructorOptions) {
constructor ({ autoTrack = true, url = COUNTLY_API_URL, appKey, metricsService }: MetricsProviderConstructorOptions<T>) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opt: long lines can be split

Suggested change
constructor ({ autoTrack = true, url = COUNTLY_API_URL, appKey, metricsService }: MetricsProviderConstructorOptions<T>) {
constructor ({
autoTrack = true,
url = COUNTLY_API_URL,
appKey,
metricsService
}: MetricsProviderConstructorOptions<T>) {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually the lint will fix this when it needs breaking out. We shouldn't need to worry about style things like this since our build does it (should do it?) for us.

And if we want it to be broken up earlier, we should update rules so that it happens automatically.

@SgtPooki SgtPooki merged commit 0f237fb into main Jan 18, 2023
@SgtPooki SgtPooki deleted the fix-dep-import branch January 18, 2023 17:44
github-actions bot pushed a commit that referenced this pull request Jan 18, 2023
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
ba2db2f 
## [1.1.0](v1.0.3...v1.1.0) (2023-01-18)

### Features

* export for browser and node ([47c500e](47c500e))

### Trivial Changes

* fix ipfs-companion import error ([#60](#60)) ([0f237fb](0f237fb))
* run 'ncu -u' ([#50](#50)) ([c5d060e](c5d060e))
@github-actions
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

whizzzkid added a commit that referenced this pull request Jan 18, 2023
@whizzzkid
Merge branch 'main' into feat/epoch
474557a 
* main:
  chore(release): 1.1.0 [skip ci]
  feat: export for browser and node
  chore: fix ipfs-companion import error (#60)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whizzzkid whizzzkid whizzzkid approved these changes

@0xDanomite 0xDanomite Awaiting requested review from 0xDanomite

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SgtPooki @whizzzkid