Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mock time implementation #762

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Replace mock time implementation #762

merged 3 commits into from
Dec 17, 2024

Conversation

gammazero
Copy link
Contributor

The package github.com/benbjohnson/clock is archived, i.e. no longer maintained, and should be replaced with a fork that is maintained. The github.com/filecoin-project/go-clock is such a fork and has fixes to existing issues in the original package.

Closes #753

The package `github.com/benbjohnson/clock` is archived, i.e. no longer maintained, and should be replaced with a fork that is maintained. The `github.com/filecoin-project/go-clock` is such a fork and has fixes to existing issues in the original package.

Closes #753
@gammazero gammazero requested a review from a team as a code owner December 17, 2024 17:11
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.34%. Comparing base (6151dae) to head (d909bfe).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
- Coverage   60.45%   60.34%   -0.12%     
==========================================
  Files         245      245              
  Lines       31101    31101              
==========================================
- Hits        18803    18768      -35     
- Misses      10629    10659      +30     
- Partials     1669     1674       +5     
Files with missing lines Coverage Δ
...client/internal/messagequeue/donthavetimeoutmgr.go 93.98% <ø> (ø)
...tswap/client/internal/messagequeue/messagequeue.go 84.54% <ø> (-0.77%) ⬇️
bitswap/server/internal/decision/scoreledger.go 94.11% <ø> (ø)
routing/http/client/client.go 70.83% <ø> (ø)

... and 12 files with indirect coverage changes

@gammazero gammazero merged commit 7489b98 into main Dec 17, 2024
14 of 15 checks passed
@gammazero gammazero deleted the change-mock-time-impl branch December 17, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace package github.com/benbjohnson/clock with github.com/filecoin-project/go-clock
1 participant