-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: using slices.Contains to simplify the code #791
Conversation
Signed-off-by: dashangcun <[email protected]>
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #791 +/- ##
==========================================
- Coverage 60.60% 60.48% -0.12%
==========================================
Files 245 245
Lines 31139 31139
==========================================
- Hits 18871 18834 -37
- Misses 10598 10629 +31
- Partials 1670 1676 +6 |
We need a label for AI contributions so that we put them all together in a single PR every couple of months. |
@hsanjuan, See https://github.com/ipfs/community/pull/783/files. Let's merge it, and create a new tag, |
Not AI, I'm a real person... |
This is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.