Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using slices.Contains to simplify the code #791

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

dashangcun
Copy link
Contributor

This is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

@dashangcun dashangcun requested a review from a team as a code owner January 13, 2025 10:44
Copy link

welcome bot commented Jan 13, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@lidel lidel requested a review from gammazero January 14, 2025 15:51
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.48%. Comparing base (720d617) to head (b0a128d).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
- Coverage   60.60%   60.48%   -0.12%     
==========================================
  Files         245      245              
  Lines       31139    31139              
==========================================
- Hits        18871    18834      -37     
- Misses      10598    10629      +31     
- Partials     1670     1676       +6     

see 15 files with indirect coverage changes

@hsanjuan
Copy link
Contributor

We need a label for AI contributions so that we put them all together in a single PR every couple of months.

@gammazero
Copy link
Contributor

@hsanjuan, See https://github.com/ipfs/community/pull/783/files. Let's merge it, and create a new tag, kind/drive-by, that references that section in the description.

@dashangcun
Copy link
Contributor Author

We need a label for AI contributions so that we put them all together in a single PR every couple of months.

Not AI, I'm a real person...

@gammazero gammazero merged commit b62b60e into ipfs:main Jan 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants