Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unnecessary logging work #826

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Reduce unnecessary logging work #826

merged 1 commit into from
Jan 31, 2025

Conversation

gammazero
Copy link
Contributor

No description provided.

@gammazero gammazero requested a review from a team as a code owner January 31, 2025 21:09
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.47%. Comparing base (0a0b298) to head (0bead48).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bitswap/client/client.go 0.00% 6 Missing and 2 partials ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
+ Coverage   60.34%   60.47%   +0.12%     
==========================================
  Files         240      244       +4     
  Lines       31016    31095      +79     
==========================================
+ Hits        18718    18805      +87     
+ Misses      10621    10616       -5     
+ Partials     1677     1674       -3     
Files with missing lines Coverage Δ
bitswap/client/internal/getter/getter.go 81.57% <ø> (-0.24%) ⬇️
...tswap/client/internal/messagequeue/messagequeue.go 85.42% <100.00%> (+1.12%) ⬆️
bitswap/client/internal/session/session.go 90.56% <100.00%> (+0.37%) ⬆️
bitswap/server/server.go 56.04% <ø> (-0.53%) ⬇️
bitswap/client/client.go 84.77% <0.00%> (-0.75%) ⬇️

... and 14 files with indirect coverage changes

@gammazero gammazero merged commit b15619e into main Jan 31, 2025
16 checks passed
@gammazero gammazero deleted the reduce-log-work branch January 31, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant