ensure dagreaders are cleaned up after 'cat' command finishes #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There appears to be a test failing... really not sure why. |
whyrusleeping
force-pushed
the
fix/readerclose
branch
from
56cf7b1 to
061a866
Compare
|
Good catch. |
jbenet
added a commit
that referenced
this pull request
Feb 2, 2015
ensure dagreaders are cleaned up after 'cat' command finishes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I beleive i found a goroutine leak bug, if a cat were to be killed before all the data was read, it wouldnt release the underlying processes. This makes sure to pass the correct context into the DagReader