Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use multihash not shasum #764

Merged
merged 2 commits into from
Feb 9, 2015
Merged

Use multihash not shasum #764

merged 2 commits into from
Feb 9, 2015

Conversation

chriscool
Copy link
Contributor

No description provided.

@chriscool
test: use multihash instead of shasum in tests
fe1ba2b 
As shasum is not installed on all machines and
we use multihash anyway in the code base, it
removes one dependency to use shasum instead of
shasum in the tests.

Now that there are sharness tests in multihash
it is also safe to use it.

License: MIT
Signed-off-by: Christian Couder <[email protected]>
@chriscool
t0040: use multihash instead of shasum in tests
391b5a3 
License: MIT
Signed-off-by: Christian Couder <[email protected]>
@btc btc added the status/in-progress In progress label Feb 8, 2015
@chriscool
Copy link
Contributor Author

@jbenet There is this error on Travis:

expecting success:
IPFS_PID=$! &&
test_wait_output_n_lines_60_sec actual_daemon 2 &&
test_run_repeat_60_sec "grep \"API server listening on $ADDR_API\" actual_daemon" ||
test_fsh cat actual_daemon || test_fsh cat daemon_err
> cat actual_daemon
Initializing daemon...
Gateway server listening on /ip4/127.0.0.1/tcp/8080
> cat daemon_err
not ok 4 - 'ipfs daemon' is ready

It looks like we are expecting "API server..." and we get "Gateway server..."
Maybe a problem in f1d34a2?

@jbenet
Copy link
Member

jbenet commented Feb 8, 2015

It looks like we are expecting "API server..." and we get "Gateway server..."

It's supposed to have both. The test is right to fail, as the API hasn't come up in >60s-- but there's a bad failure going on: maybe binding to the port fails, and it fails silently? (it's really annoying as happens all the time, and not clear to me what's going on)

@chriscool
Copy link
Contributor Author

Ok. If there are other important steps between the Gateway coming up and the API coming up, maybe other messages could be printed and checked in the tests. That could narrow down which code is failing.

Or could it be a network failure, and are there ways to monitor those on Travis?

Anyway it is not related to the changes in this PR.

@jbenet
Copy link
Member

jbenet commented Feb 9, 2015

Or could it be a network failure, and are there ways to monitor those on Travis?

I think it is-- there's nothing important between the gateway and API. the likely explanation is a port clash. I think it may be best to move towards making the API able to start on an unspecified (kernel assigned) port. (this is non trivial at the moment).

Anyway it is not related to the changes in this PR.

LGTM, thanks!

jbenet added a commit that referenced this pull request Feb 9, 2015
@jbenet
Merge pull request #764 from jbenet/use_multihash_not_shasum
931cff2 
Use multihash not shasum
@jbenet jbenet merged commit 931cff2 into master Feb 9, 2015
@jbenet jbenet removed the status/in-progress In progress label Feb 9, 2015
@jbenet jbenet deleted the use_multihash_not_shasum branch February 9, 2015 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriscool @jbenet @btc