Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have repo tilde expand paths #775

Merged
merged 1 commit into from
Feb 13, 2015
Merged

have repo tilde expand paths #775

merged 1 commit into from
Feb 13, 2015

Conversation

whyrusleeping
Copy link
Member

As I work through examples, I feel like it would be much easier for the fsrepo to tilde expand paths given to it. This makes it much easier for users to write the following code:

r := fsrepo.At("~/.go-ipfs")

instead of:

home := os.GetEnv("HOME")
if len(home) == 0 {
    panic("WHAT IS HAPPENING?")
}
r := fsrepo.At(home + "/.go-ipfs")

@whyrusleeping whyrusleeping added the status/in-progress In progress label Feb 12, 2015
@jbenet
Copy link
Member

jbenet commented Feb 12, 2015

I'm fine with this. i dont know all the places its used and whether that violates any assumptions. but tests pass so i guess that's fine.

@jbenet
Copy link
Member

jbenet commented Feb 12, 2015

changes lgtm

@whyrusleeping
Copy link
Member Author

I think that anything user facing should accept as wide an array of inputs as possible

whyrusleeping added a commit that referenced this pull request Feb 13, 2015
@whyrusleeping whyrusleeping merged commit d4d3e29 into master Feb 13, 2015
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Feb 13, 2015
@whyrusleeping whyrusleeping deleted the fix/repo-tilde branch February 13, 2015 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants