Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Portuguese channels #15708

Merged
merged 13 commits into from
Mar 2, 2025
Merged

Add Portuguese channels #15708

merged 13 commits into from
Mar 2, 2025

Conversation

thomraider12
Copy link
Contributor

added:

  • StarChannel.pt
  • StarLife.pt
  • StarComedy.pt
  • StarMovies.pt

changed logo of:

  • VPlusTVI.pt

added:
- StarChannel.pt
- StarLife.pt
- StarComedy.pt
- StarMovies.pt

changed logo of:
- VPlusTVI.pt
@Alstruit
Copy link
Contributor

Alstruit commented Feb 2, 2025

https://github.com/iptv-org/database/blob/master/CONTRIBUTING.md

@Alstruit Alstruit closed this Feb 2, 2025
@thomraider12
Copy link
Contributor Author

https://github.com/iptv-org/database/blob/master/CONTRIBUTING.md

That's what I did. No clue why you closed it.

@PopeyeTheSai10r
Copy link
Contributor

PopeyeTheSai10r commented Feb 7, 2025

Hey @thomraider12, Which ever code editor you used to made the changes saved the file incorrectly. It saved it as if everything was changed.

https://github.com/iptv-org/database/pull/15708/files

39,195 additions, 39,190 deletions not shown because the diff is too large. Please use a local Git client to view these changes.

You will either need to use a different editor or try submitting the changes via issues.

@thomraider12
Copy link
Contributor Author

Ok, thanks.

@BellezaEmporium
Copy link
Contributor

Reopening on my behalf, found the issue.

@BellezaEmporium
Copy link
Contributor

Now we're seeing something.

@BellezaEmporium
Copy link
Contributor

Here's why your PR isn't passing the tests :

27657 "StarComedy.pt" must be derived from the channel name "STAR Comedy" and the country code "PT"
27660 "StarCrime.pt" must be derived from the channel name "STAR Crime" and the country code "PT"
27688 "StarLife.pt" must be derived from the channel name "STAR Life" and the country code "PT"

^ For these specific errors, the bot asks you to be coherent with your naming choices. If you name a channel STAR Comedy, then the ID should be STARComedy.pt.

27660 "StarCrime.pt" has an invalid categories "crime"

^ For this error, we will ask you to check the categories we accept at https://github.com/iptv-org/database/blob/master/data/categories.csv, and choose the closest category (or categories) corresponding to your channel.

27657 StarComedy.pt: "logo" has an invalid file extension ".svg"
27660 StarCrime.pt: "logo" has an invalid file extension ".svg"
27702 STARMovies.pt: "logo" has an invalid file extension ".svg"

^ For these errors, we will ask you to use .png, or .jpg images. The bot and programs using the database do not understand the .svg format yet, so please refrain from using them. Please use the .jpg, .jpeg. or .png format for the logos.

@thomraider12
Copy link
Contributor Author

Here's why your PR isn't passing the tests :

27657 "StarComedy.pt" must be derived from the channel name "STAR Comedy" and the country code "PT" 27660 "StarCrime.pt" must be derived from the channel name "STAR Crime" and the country code "PT" 27688 "StarLife.pt" must be derived from the channel name "STAR Life" and the country code "PT"

^ For these specific errors, the bot asks you to be coherent with your naming choices. If you name a channel STAR Comedy, then the ID should be STARComedy.pt.

27660 "StarCrime.pt" has an invalid categories "crime"

^ For this error, we will ask you to check the categories we accept at https://github.com/iptv-org/database/blob/master/data/categories.csv, and choose the closest category (or categories) corresponding to your channel.

27657 StarComedy.pt: "logo" has an invalid file extension ".svg" 27660 StarCrime.pt: "logo" has an invalid file extension ".svg" 27702 STARMovies.pt: "logo" has an invalid file extension ".svg"

^ For these errors, we will ask you to use .png, or .jpg images. The bot and programs using the database do not understand the .svg format yet, so please refrain from using them. Please use the .jpg, .jpeg. or .png format for the logos.

I will try to fix that tomorrow. My PC broke down and when it gets fixed I'll do it. Thanks man.

@BellezaEmporium BellezaEmporium marked this pull request as draft February 14, 2025 23:43
@thomraider12
Copy link
Contributor Author

What about now? I think I solved all those problems.

@thomraider12 thomraider12 marked this pull request as ready for review February 16, 2025 14:07
@BellezaEmporium
Copy link
Contributor

BellezaEmporium commented Feb 17, 2025

31083 "TVIFiccao.pt" must be derived from the channel name "TVI Ficção" and the country code "PT"
31083 TVIFiccao.pt: "name" with value "TVI Ficção" fails to match the required pattern: /^[a-z0-9-!:&.+'/»#%°$@?|¡–\s_—]+$/i

Main rule for the channel name is to write the channel name without any accents, and then "romanize the name" as an alternative name, to make sure all browsers and players can read the channel name properly.

@thomraider12
Copy link
Contributor Author

31083 "TVIFiccao.pt" must be derived from the channel name "TVI Ficção" and the country code "PT" 31083 TVIFiccao.pt: "name" with value "TVI Ficção" fails to match the required pattern: /^[a-z0-9-!:&.+'/»#%°$@?|¡–\s_—]+$/i

Main rule for the channel name is to write the channel name without any accents, and then "romanize the name" as an alternative name, to make sure all browsers and players can read the channel name properly.

Oh, thanks.

Copy link
Contributor

@Alstruit Alstruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See requested changes.

@freearhey
Copy link
Contributor

@Alstruit Fixed.

@thomraider12 thomraider12 requested a review from Alstruit March 2, 2025 15:56
@Alstruit Alstruit merged commit dc9f5b8 into iptv-org:master Mar 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants