Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: general clean up (code, text, links) #383

Closed
wants to merge 22 commits into from
Closed

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Nov 18, 2022

No description provided.

@shcheklein shcheklein temporarily deployed to cml-dev-ref-cleanup-zazbgfz9gv November 18, 2022 08:50 Inactive
@jorgeorpinel

This comment was marked as resolved.

@jorgeorpinel jorgeorpinel added documentation Markdown files p2-nice-to-have Low priority labels Nov 18, 2022
[checks interface](https://docs.github.com/en/rest/reference/checks).
Posts a Markdown report using GitHub's
[Checks API](https://docs.github.com/en/rest/reference/checks).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

github-actions bot commented Nov 18, 2022

Link Check Report

All 33 links passed!

@shcheklein shcheklein temporarily deployed to cml-dev-ref-cleanup-zazbgfz9gv December 7, 2022 01:13 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review December 7, 2022 01:13
@shcheklein shcheklein temporarily deployed to cml-dev-ref-cleanup-s1eq2s4ch1 December 16, 2022 00:08 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-ref-cleanup-s1eq2s4ch1 December 27, 2022 18:35 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as draft December 27, 2022 20:46
@jorgeorpinel jorgeorpinel changed the base branch from config--ref to master December 27, 2022 20:46
@jorgeorpinel jorgeorpinel removed the request for review from casperdcl December 27, 2022 20:47
@shcheklein shcheklein temporarily deployed to cml-dev-ref-cleanup-s1eq2s4ch1 December 27, 2022 21:01 Inactive
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rolling back changes pertaining to #382

@shcheklein shcheklein had a problem deploying to cml-dev-ref-cleanup-s1eq2s4ch1 December 27, 2022 21:05 Failure
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah and @casperdcl does not like md link refs... ⏳

@shcheklein shcheklein temporarily deployed to cml-dev-ref-cleanup-s1eq2s4ch1 December 27, 2022 21:11 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-ref-cleanup-s1eq2s4ch1 December 27, 2022 21:13 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-ref-cleanup-s1eq2s4ch1 December 27, 2022 21:14 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review December 27, 2022 21:14
@jorgeorpinel jorgeorpinel requested a review from a team as a code owner December 27, 2022 21:14
@jorgeorpinel
Copy link
Contributor Author

Not sure why this is nested into #382

Made this PR independent now! This can be reviewed any time (according to priority).

@jorgeorpinel jorgeorpinel requested a review from a team December 27, 2022 21:15
@jorgeorpinel

This comment was marked as resolved.

@jorgeorpinel jorgeorpinel removed their assignment Feb 23, 2023
@jorgeorpinel
Copy link
Contributor Author

Can't push to this repo anymore but I've resolved conflicts in my branch, now in a fork. Closing this one for now but it can be recovered in:

https://github.com/iterative/cml.dev/compare/master...jorgeorpinel:cml.dev:ref/cleanup?expand=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Markdown files p2-nice-to-have Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants