Improve commentCreate error message when the pull request can't be found #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x2b3bfa0
added
bug
0x2b3bfa0
commented
Oct 29, 2021
|
|
||
| const [prNumber] = url.split('/').slice(-1); | ||
|
|
||
| if (!commitPr || !commitPr.url) |
There was a problem hiding this comment.
Only if merged after #783
Suggested change
| if (!commitPr || !commitPr.url) | |
| if (!commitPr?.url) |
0x2b3bfa0
force-pushed
the
improve-comment-create-error
branch
from
cf8af36 to
b04204f
Compare
|
This is ugly. And the error is properly documented. The main reason is the missed destructuring const { url } = commitPr || {}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #606
Before
error: Cannot destructure property 'url' of 'commitPr' as it is undefined.After
error: PR for commit sha "ff404ff" not found