Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvclive: Document more monitoring options #4306

Merged
merged 6 commits into from
Feb 13, 2023
Merged

dvclive: Document more monitoring options #4306

merged 6 commits into from
Feb 13, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Feb 9, 2023

@daavoo daavoo requested a review from a team February 9, 2023 08:38
@daavoo daavoo requested a review from a team as a code owner February 9, 2023 08:38
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-noteboo-ktfwfc February 9, 2023 08:38 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Link Check Report

There were no links to check!

[Studio Live Experiments](/doc/studio/user-guide/projects-and-experiments/live-metrics-and-plots),
DVCLive updates will be displayed in the Studio UI:

![Studio Report](/img/dvclive-studio.gif)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The live metrics line in the plot in this gif starts at step 9. I think that the live update of this line would be clearer to the user if it started at 3rd or 4th step and continued for another 3-4 steps.

Also, my understanding is that we should upload all the images/gifs used in the docs to the static repo. Don't we use that for the DVCLive docs assets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The live metrics line in the plot in this gif starts at step 9. I think that the live update of this line would be clearer to the user if it started at 3rd or 4th step and continued for another 3-4 steps.

👍 will update

Also, my understanding is that we should upload all the images/gifs used in the docs to the static repo. Don't we use that for the DVCLive docs assets?

I was not aware of that. Previously (and this P.R) I added images to https://github.com/iterative/dvc.org/tree/main/static/img . Did something change? Where is the process described?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did something change? Where is the process described?

In my very first docs PR, @casperdcl made this suggestion here and here. I believe it was discussed and decided prior to that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgeorpinel Can you weigh in about how to add images? I've also never heard of this before 😅 .

Copy link
Contributor

@casperdcl casperdcl Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what the current status is either. AFAIK (at least in https://iterative.ai/blog) we "do the right thing" and use DVC for the images.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only add images via DVC in the blog on iterative.ai, all docs images are generally popped into the repo plainly under the /static/img directory. Almost certainly not best practice, but until we get the process fully sorted out in the blog we've opted not to change things for other images since the blog easily has the lion's share of images and much more capacity to grow.

@jorgeorpinel jorgeorpinel changed the title dvclive: Document notebook and Studio live experiments. dvclive: notebook and Studio live experiments Feb 10, 2023
@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) C: dvclive Content of /doc/dvclive C: ref Content of /doc/*-reference labels Feb 10, 2023
@jorgeorpinel
Copy link
Contributor

Very cool. Lmk if you need an approval, thanks @daavoo !

@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-noteboo-ktfwfc February 10, 2023 12:16 Inactive
@daavoo daavoo changed the title dvclive: notebook and Studio live experiments dvclive: Document more monitoring options Feb 10, 2023
@daavoo daavoo requested a review from tapadipti February 10, 2023 12:25

</tab>

<tab title="CML">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @casperdcl I think this is the first mention ever in the docs for the "DVCLive + CML" use case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't matplotlib required? Do we document that anywhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think it's the most complex and narrow scenario. Should we move it to the last tab?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't matplotlib required? Do we document that anywhere?

In https://dvc.org/doc/dvclive/api-reference/live#parameters . I also added a mention inside the tab

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think it's the most complex and narrow scenario. Should we move it to the last tab?

Done

@daavoo daavoo requested a review from dberenbaum February 10, 2023 12:29
@dberenbaum
Copy link
Contributor

LGTM! Should we also document the different modes more in the API ref under the report arg and make_report()?

@daavoo daavoo mentioned this pull request Feb 13, 2023
2 tasks
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-noteboo-ktfwfc February 13, 2023 11:39 Inactive
@daavoo daavoo merged commit a4686b4 into main Feb 13, 2023
@daavoo daavoo deleted the dvclive-notebook branch February 13, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: dvclive Content of /doc/dvclive C: ref Content of /doc/*-reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants