-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dvclive: Document more monitoring options #4306
Conversation
[Studio Live Experiments](/doc/studio/user-guide/projects-and-experiments/live-metrics-and-plots), | ||
DVCLive updates will be displayed in the Studio UI: | ||
|
||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The live metrics line in the plot in this gif starts at step 9. I think that the live update of this line would be clearer to the user if it started at 3rd or 4th step and continued for another 3-4 steps.
Also, my understanding is that we should upload all the images/gifs used in the docs to the static repo. Don't we use that for the DVCLive docs assets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The live metrics line in the plot in this gif starts at step 9. I think that the live update of this line would be clearer to the user if it started at 3rd or 4th step and continued for another 3-4 steps.
👍 will update
Also, my understanding is that we should upload all the images/gifs used in the docs to the static repo. Don't we use that for the DVCLive docs assets?
I was not aware of that. Previously (and this P.R) I added images to https://github.com/iterative/dvc.org/tree/main/static/img . Did something change? Where is the process described?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did something change? Where is the process described?
In my very first docs PR, @casperdcl made this suggestion here and here. I believe it was discussed and decided prior to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgeorpinel Can you weigh in about how to add images? I've also never heard of this before 😅 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what the current status is either. AFAIK (at least in https://iterative.ai/blog) we "do the right thing" and use DVC for the images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only add images via DVC in the blog on iterative.ai, all docs images are generally popped into the repo plainly under the /static/img
directory. Almost certainly not best practice, but until we get the process fully sorted out in the blog we've opted not to change things for other images since the blog easily has the lion's share of images and much more capacity to grow.
Very cool. Lmk if you need an approval, thanks @daavoo ! |
content/docs/dvclive/get-started.md
Outdated
|
||
</tab> | ||
|
||
<tab title="CML"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @casperdcl I think this is the first mention ever in the docs for the "DVCLive + CML" use case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't matplotlib required? Do we document that anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think it's the most complex and narrow scenario. Should we move it to the last tab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't matplotlib required? Do we document that anywhere?
In https://dvc.org/doc/dvclive/api-reference/live#parameters . I also added a mention inside the tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think it's the most complex and narrow scenario. Should we move it to the last tab?
Done
LGTM! Should we also document the different modes more in the API ref under the |
notebook
from report: Addnotebook
mode. dvclive#432