Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Redesign #367

Closed
arjpar opened this issue Feb 17, 2019 · 14 comments
Closed

Request: Redesign #367

arjpar opened this issue Feb 17, 2019 · 14 comments
Labels
enhancement Improvement of an existing feature stale

Comments

@arjpar
Copy link

arjpar commented Feb 17, 2019

I was wondering if in the long term there could be a redesign for the site. This issue is somewhat related to #4. I'm willing to create a few designs and implement it in CSS. These designs wouldn't be anything revolutionary - I'm thinking a generally lightweight design that doesn't change the overall structure of the existing design.

Do you think that bootstrap could be an option?

@omarroth
Copy link
Contributor

I've received a couple other messages about this. There's some discussion on a similar feature in FreeTubeApp/FreeTube#38. My thoughts on this are similar to @PrestonN's.

Currently Invidious uses purecss, and some custom styling in assets/css/default.css, assets/css/lighttheme.css, and assets/css/darktheme.css. You'll probably want to look there for getting started. I would recommend creating a new assets/css/themename.css and opening a PR.

I'm not very familiar with Bootstrap, but if you want to use another CSS framework you'll want to make sure it's compatible with the AGPL. Most open-source licenses will generally be fine.

I think trying to switch to and use another framework would be quite a bit of work, so if you can, I'd recommend trying to modify the existing design using the method I described above.

@shortenjukebox
Copy link

I personally dig the current design’s minimalism, both aesthetically and in its use of resources. JavaScript being optional is a huge plus. It looks non-descript enough that it hopefully won’t draw too much attention from [The Company That Shall Not Be Named].

I suppose I’d prefer the navigation bar to be ~25 pixels shorter, so the whole video player fits above-the-fold on my tiny laptop screen.

@omarroth omarroth added the enhancement Improvement of an existing feature label Feb 21, 2019
@poperigby
Copy link

Would Google be able to shut down Invidious?

@Perflyst
Copy link
Contributor

Perflyst commented May 6, 2019 via email

@poperigby
Copy link

So why haven't they? Makes me uneasy that they could shut this down at any second.

@omarroth
Copy link
Contributor

omarroth commented May 6, 2019

In future please open a new issue rather than asking in an unrelated issue.

See #130. Invidious works similarly to youtube-dl and NewPipe, which also have information on this. Invidious is not, to my understanding, at risk of legal threats, since it does not use the official YouTube API.

@poperigby
Copy link

Alright. Sorry about that

@trymeouteh
Copy link

I think PureCSS would work well for a redesign but honestly the site does not look that bad.

@practik
Copy link

practik commented May 31, 2019

Overall I like the design as well, but I was already using YouTube in theater mode, so the layout of Invidious is quite similar to what I was used to. My only suggestions would be:

  • In the related videos column, putting the thumbnails and descriptions side by side (i.e., the way YouTube does it) would save space (meaning you don't have to scroll as far) and make it clearer which description belongs to which thumbnail.
  • For those of us who just want to tweak the layout with some custom CSS on our own browsers, it would help a lot if every element had an id and/or class. Currently a lot of the p elements don't have either (view count, video length, video title, etc.), so to target them you have to resort to stuff like .pure-u-lg-1-5:first-of-type p:nth-of-type(2).

@elypter
Copy link

elypter commented Jun 3, 2019

In the related videos column, putting the thumbnails and descriptions side by side (i.e., the way YouTube does it) would save space (meaning you don't have to scroll as far) and make it clearer which description belongs to which thumbnail

This has the downside that the video description section will get squeezed to much on an non wide screen or smaller monitor. it could be part of a fluid adapting design though

@arjpar
Copy link
Author

arjpar commented Aug 5, 2019

So I now have the time to get working on this, but I'm not sure if this is a highly requested feature. If there is substantial interest then I could get to work on making some things a bit prettier, perhaps similar to the FreeTube layout although I haven't used FreeTube in a while.

@poperigby
Copy link

So I now have the time to get working on this, but I'm not sure if this is a highly requested feature. If there is substantial interest then I could get to work on making some things a bit prettier, perhaps similar to the FreeTube layout although I haven't used FreeTube in a while.

I'd certainly be interested.

@Perflyst
Copy link
Contributor

Perflyst commented Aug 5, 2019 via email

@github-actions
Copy link

github-actions bot commented Dec 2, 2020

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

@github-actions github-actions bot added the stale label Dec 2, 2020
@github-actions github-actions bot closed this as completed Jan 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of an existing feature stale
Projects
None yet
Development

No branches or pull requests

8 participants