Improve: Translator use empty struct instead of nil pointer #6798
Labels
Comments
This was referenced Mar 4, 2025
github-merge-queue bot
pushed a commit
that referenced
this issue
Mar 5, 2025
## Which problem is this PR solving? - Resolves #6798 ## Description of the changes - Added boundary case handling for empty fields during model conversion. ## How was this change tested? - unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: zzzk1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requirement
The current method for converting
ptrace.Tracestomodel.tracedoes not account for the conversion of nested structs (nil), which causes assertion failures in integration tests.Problem
Integration tests failed.
Proposal
No response
Open questions
No response
The text was updated successfully, but these errors were encountered: