Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax adaptive sampling dependency on sampler tags #6692

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Feb 8, 2025

Which problem is this PR solving?

Description of the changes

  • Introduce an opt-in option to allow the engine to operate without sampler tags

How was this change tested?

  • TBD

@yurishkuro yurishkuro requested a review from a team as a code owner February 8, 2025 14:18
@dosubot dosubot bot added the area/sampling label Feb 8, 2025
Signed-off-by: Yuri Shkuro <[email protected]>
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.96%. Comparing base (24dfa4f) to head (d8b0bcf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pling/samplingstrategy/adaptive/post_aggregator.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6692      +/-   ##
==========================================
- Coverage   95.98%   95.96%   -0.02%     
==========================================
  Files         363      363              
  Lines       20608    20606       -2     
==========================================
- Hits        19780    19775       -5     
- Misses        632      634       +2     
- Partials      196      197       +1     
Flag Coverage Δ
badger_v1 9.82% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1-manual 14.79% <ø> (ø)
cassandra-4.x-v2-auto 1.81% <ø> (ø)
cassandra-4.x-v2-manual 1.81% <ø> (ø)
cassandra-5.x-v1-manual 14.79% <ø> (ø)
cassandra-5.x-v2-auto 1.81% <ø> (ø)
cassandra-5.x-v2-manual 1.81% <ø> (ø)
elasticsearch-6.x-v1 19.12% <ø> (ø)
elasticsearch-7.x-v1 19.20% <ø> (ø)
elasticsearch-8.x-v1 19.37% <ø> (ø)
elasticsearch-8.x-v2 1.82% <ø> (ø)
grpc_v1 10.80% <ø> (ø)
grpc_v2 7.80% <ø> (ø)
kafka-3.x-v1 10.12% <ø> (ø)
kafka-3.x-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 19.25% <ø> (ø)
opensearch-2.x-v1 19.25% <ø> (ø)
opensearch-2.x-v2 1.82% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.85% <78.57%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro changed the title Relax adaptive sampling dependency on samlper tags Relax adaptive sampling dependency on sampler tags Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant