Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: introduce DAOS dtx tests (DAOS patches review) #27

Open
wants to merge 10 commits into
base: release/2.6
Choose a base branch
from
Open

test: introduce DAOS dtx tests (DAOS patches review) #27

wants to merge 10 commits into from

Conversation

janekmi
Copy link
Owner

@janekmi janekmi commented Oct 2, 2024 •
edited
Loading

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

This change is Reviewable

@janekmi janekmi requested a review from grom72 October 2, 2024 14:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/test:

@janekmi janekmi mentioned this pull request Oct 2, 2024
Open
janekmi added 10 commits October 2, 2024 14:22
@janekmi
00_harmonize_VOS_pool_path
1492e3e 
Required-githooks: true
@janekmi
01_stop_using_test_args_reset
80ad2e9 
The use of the test_args_reset() utility breaks the setup/teardown symmetry.
If a test requires a pool/container to be recreated it has to do it in its
setup/teardown instead of relying on the test suite setup/teardown
(e.g. setup_io/teardown_io) and then calling test_args_reset() over and over
again. If a pool/container has been created in the setup, it should be destroyed
in the respective teardown.

Required-githooks: true

Signed-off-by: Jan Michalski <[email protected]>
@janekmi
02_reduce_memory_requirements
051a1f7 
Required-githooks: true

Signed-off-by: Jan Michalski <[email protected]>
@janekmi
03_CMOCKA_FILTER_SUPPORTED
aadfa21 
Required-githooks: true

Signed-off-by: Jan Michalski <[email protected]>
@janekmi
04_force_use_sys_db
147fe6b 
Required-githooks: true
@janekmi
05_dts_basic_create_open_close
2009c3f 
Required-githooks: true

Signed-off-by: Jan Michalski <[email protected]>
@janekmi
06_basic_dtx_ut
dfcb538 
Required-githooks: true

Signed-off-by: Jan Michalski <[email protected]>
@janekmi
07_disable_ABT
ea926c8 
Required-githooks: true
@janekmi
08_cmocka_filter_fix
22e10a5 
Required-githooks: true

Signed-off-by: Jan Michalski <[email protected]>
@janekmi
09_fix_size_t_from_int
2b43bab 
Required-githooks: true

Signed-off-by: Jan Michalski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grom72 grom72 Awaiting requested review from grom72

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janekmi