Changing logic of isDirty to match with Laravel 5.5 and prevent from always returning false #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #15.
This PR changes the if statement in
isDirty
so that an empty array will be passed in when no arguments are specified, sohasChanges
works properly. I have tested the changes and they fix the issue and allow model update operations to function again.See laravel/framework#20130 for what was changed in Laravel 5.5 as it relates to
isDirty
. We now need to pass in an array instead of allowing null as hasChanges() inIlluminate\Database\Eloquent\Concerns\HasAttributes
is checking for an empty array instead of null. This package'sisDirty
was effectively doingparent::isDirty(null);
with the default argument, sofunc_get_args()
inside Laravel'sisDirty
was returning[null]
and screwing everything up.