Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overriding default_env in capistrano #728

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

ta1kt0me
Copy link
Contributor

Commands always include RAILS_ENV in environment variables after executed `whenever:update_crontab'. I think It's unintended for not rails task. Depending on the user's privileges, below error occurs,

stderr: sudo: sorry, you are not allowed to set the following environment variables: RAILS_ENV

It isn't secure to change sudoer's setting for avoiding it. whenever_command_environment_variables is the variable for whenever only, so the side effects that affect other tasks should be eliminated.

It's unintended not for rails task to include RAILS_ENV in
environemnt varibales.
@ta1kt0me ta1kt0me changed the title Avoid overriding default_env with capistrano Avoid overriding default_env in capistrano Nov 21, 2017
@benlangfeld benlangfeld merged commit 829fb20 into javan:master Nov 27, 2017
@ta1kt0me ta1kt0me deleted the unexpected_override_default_env branch November 28, 2017 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants