Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add username option to redis config #218

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Conversation

erdos4d
Copy link

@erdos4d erdos4d commented Jun 5, 2022

When setting DEFENDER_REDIS_URL, add capability to use non-default username.

@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #218 (eab8a1e) into master (0b96c53) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   92.46%   92.50%   +0.03%     
==========================================
  Files          13       13              
  Lines         398      400       +2     
==========================================
+ Hits          368      370       +2     
  Misses         30       30              
Impacted Files Coverage Δ
defender/connection.py 96.77% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b96c53...eab8a1e. Read the comment docs.

@erdos4d erdos4d requested a review from aleksihakli June 5, 2022 20:16
@aleksihakli
Copy link
Member

LGTM, thank you for the PR :) @kencochrane is the person who can make a new version release to PyPI for django-defender.

@aleksihakli aleksihakli merged commit bb122f2 into jazzband:master Jun 6, 2022
@kencochrane
Copy link
Collaborator

It should be released to pypi. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants