Unity's Windows Runtime changes #394
Conversation
A type will not be fully initialized during read, so don't attempt to project for Windows runtime until after all of the metadata reading is correct. If a type reading for a module is no completed, a call to BinaryRangeSearch in MetadataSystem can fail, because some of the entries in the types array will still be null.
TautvydasZilys
force-pushed
the
upstream-master-staging
branch
2 times, most recently
from
8dd513f to
670fd30
Compare
…y identify two method references to be the same if they had the same declaring types, the same parameter counts and were both unresolvable.
TautvydasZilys
force-pushed
the
upstream-master-staging
branch
from
670fd30 to
90a49c4
Compare
…uality comparer and also add tests for them.
|
@jbevain are there any changes you want to see before you would land this? |
|
@mrvoorhe @TautvydasZilys can't we all collectively pretend that winmd files don't exist? |
|
@jbevain you can. Sometimes I can 😄 and @TautvydasZilys never can. My end goal is to reduce our custom changes to cecil as much as possible so that it is easier for us to track upstream master. @jbevain Based on your own comment #389 (comment) there is at least something in this PR that you are open to. Do you want us to break some pieces out of this PR? |
|
I think reducing or eliminating the difference between your version and upstream is a worthy goal. I also fully trust Tautvydas. It's me the problem. Taking this means that I'll probably end up maintaining it from my retirement home, and I just don't understand anything related to those projections because I've never had to look into them. That makes me scared to take such a large change, because in the end I have no idea what I'm taking. |
|
The counter argument to that is we already landed part the support for winmd files, and that PR fixes it. So I might as well just take it already. |
|
It sounds like you are making progress sorting out your dilemma with yourself. Keep it up! |
|
‘Tis the season to click green merge buttons |
TautvydasZilys
force-pushed
the
upstream-master-staging
branch
from
92df168 to
a4c20ac
Compare
|
Thanks for the quick fix folks, I'm glad we've been able to work diligently to get this merged. |
No description provided.