-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type reference name in attribute argument getting mangled when #722
Conversation
@@ -88,7 +88,7 @@ public void ByRefTypeReference () | |||
public void FullyQualifiedTypeReference () | |||
{ | |||
var module = GetCurrentModule (); | |||
var cecil = module.AssemblyReferences.Where (reference => reference.Name == "Mono.Cecil").First (); | |||
var cecil = module.AssemblyReferences.Where (reference => reference.Name == "Unity.Cecil").First (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
b3ad5f9
to
3891384
Compare
I can't tell if a test failed or if there was some CI instability. All I see in the log is
|
3891384
to
1a32d9b
Compare
Looks like it was a CI instability. I force pushed to trigger a new CI run and now the tests are green. |
Yeah that's NuGet having hiccups. |
Mono.Cecil/AssemblyWriter.cs
Outdated
private void WriteCustomAttributeTypeValue (TypeReference value) | ||
{ | ||
var typeDefinition = value as TypeDefinition; | ||
TypeDefinition outermostDeclaringType = typeDefinition; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this into the if branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…ch attribute is put on a method in a projected type.
1a32d9b
to
b4eef32
Compare
Thank you! |
such attribute is put on a method in a projected type.
This is a fix that Unity's cecil has had for a couple years.