Fix resolving from a ModuleReference #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnakinRaW
changed the title
|
That's related to #652. Funny that the code assumes this works. |
jbevain
changed the title
jbevain
changed the title
|
Also fix #652 |
|
changes look good for me, thanks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested here is the failing PR for #725 .
I managed to use the existing test resources
mma.exeto reproduce the error.The test simple asserts that no exception shall get thrown, but since I'm not sure how you want to handle this situation, this is just a placeholder and should be replaced once a decision on actual behavior is made.