Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relative url doesn't work with video tag #28

Open
goooooouwa opened this issue Oct 11, 2020 · 6 comments
Open

relative url doesn't work with video tag #28

goooooouwa opened this issue Oct 11, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@goooooouwa
Copy link

Hi @jeffreytse ,

First of all, thanks for creating this awesome plugin. Love the features it provides.

Recently when trying to use the video tag to play one of my local video files using relative_url, it seems not recognizing the video, instead it's rendered as a normal image tag as result.

I'm using the following syntax: ![]( {{ "/assets/images/2015/12/2015-12-13-wu-biao-t2/1.mp4" | relative_url }} ).

Could you please check if it's reproducible on you end? Please share if there's any workaround.

Thanks in advance.

@jeffreytse
Copy link
Owner

Hi @goooooouwa

Thanks for your support to this plugin. Now the processor just supports the pure link of http(s), and the filter isn't supported.
Once this feature is done. I'll get back you as soon as possible.

Thanks and regards.

@jeffreytse jeffreytse self-assigned this Oct 12, 2020
@jeffreytse jeffreytse added the bug Something isn't working label Oct 12, 2020
@jeffreytse
Copy link
Owner

Hi @goooooouwa

🎉 Thanks for your help and this issue has been settled. Also, the latest gem version v0.9.4 has been released.

Thanks and regards.

@suppadeliux
Copy link

this syntax weirdly doesn't work for me. The only one that works for me is => ![](videos/demo_video.webm)

@jeffreytse
Copy link
Owner

Hi @suppadeliux

Could you please provide your code for me to dig this problem?

Thanks and regards

@suppadeliux
Copy link

suppadeliux commented Jan 22, 2021

Hello,
It is actually a little but difficult to explain, but in a few words, before the markdown is parsed and generates the html, i filter and match all paths from .md with a js filter which is in charge of copying for example my files to the _site folder, and other things.

The syntax => ![]( {{ "videos/example.webm" | relative_url }} ) can't work because of this custom js filter I use. So the problem comes from my custom filter and doesnt have something to do with jekyll-spaceship (because its parses the code always before the plugin or custom plugins). My guess is that kramdown syntax kind of lets that pass trough, and does the job of conversion/html generation, or maybe other thing I am not able to understand.

Anyways, today it does the job, and I am able to make it work ;). thanks again for the help!

@jeffreytse
Copy link
Owner

Hi @suppadeliux

I'm so glad to hear that you have settled down this problem. Anyway, welcome to submit your issue when you meet a problem.

Thanks and regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants