Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some image links were hijacked to dailymotion #51

Closed
longavailable opened this issue Apr 2, 2021 · 3 comments
Closed

Some image links were hijacked to dailymotion #51

longavailable opened this issue Apr 2, 2021 · 3 comments
Assignees
Labels
bug Something isn't working verified This issue was already verified

Comments

@longavailable
Copy link

longavailable commented Apr 2, 2021

I used a same template to generate image galleries in my site pages.
Most works fine. While I found out MediaProcessor of jekyll-spaceship was invoked accidently and the image links were hijacked to dailymotion.

image

I can not find out the bug point. So I post the pages and their sources built in my site here.

The page built correctly: https://longlovemyu.tk/vod-golden-age/
and its source: https://raw.githubusercontent.com/longavailable/longavailable.github.io/master/myCollections/_separate-pages/view-of-delft-01-golden-age.md

The page was wrongly built: https://longlovemyu.tk/vod-dl/
and its source: https://raw.githubusercontent.com/longavailable/longavailable.github.io/master/myCollections/_separate-pages/view-of-delft-04-daily-life.md

I think it was caused by jekyll-spaceship. Because I saw the following logs when I checked locally. Only one of the webpages used a template invoked MediaProcessor unexpectedly.

image

The invoked includes is located at https://raw.githubusercontent.com/longavailable/longavailable.github.io/master/_includes/image-gallery.html .

lightbox.js:
https://raw.githubusercontent.com/longavailable/longavailable.github.io/master/js/lightbox.js.

@jeffreytse jeffreytse self-assigned this Apr 2, 2021
@jeffreytse jeffreytse added the bug Something isn't working label Apr 2, 2021
@jeffreytse
Copy link
Owner

Hi @longavailable

Thank you for the reporting, I will do some further investigation.

Thanks and regards

@jeffreytse jeffreytse added the verified This issue was already verified label Apr 3, 2021
@jeffreytse
Copy link
Owner

Hi @longavailable

This issue has been addressed and fixed. Please update your plugin to the latest version.

Thanks and regards

@longavailable
Copy link
Author

Well done. It works fine right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified This issue was already verified
Projects
None yet
Development

No branches or pull requests

2 participants