Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide video player controls by default #4119

Merged

Conversation

nielsvanvelzen
Copy link
Member

When the video player opens, you probably know what is gonna play already.. because you just opened it yourself. No reason to show the controls/title by default. So let's hide it!

Changes

  • Hide video player controls by default
  • Don't automatically show video controls when playback starts
  • Fix "ask to skip" button showing on overlay on start

Issues

@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Oct 29, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.18.0 milestone Oct 29, 2024
private boolean mPopupPanelVisible = false;
private boolean navigating = false;

private LeanbackOverlayFragment leanbackOverlayFragment;
protected LeanbackOverlayFragment leanbackOverlayFragment;

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@nielsvanvelzen nielsvanvelzen merged commit 1062d7b into jellyfin:master Oct 29, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the hide-playback-overlay-default branch October 29, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants