Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new feature to create yaml including jenkins core and plugins and give users a choice to choose #620

Merged
merged 42 commits into from
Jun 15, 2022

Conversation

jxr98
Copy link
Contributor

@jxr98 jxr98 commented Aug 26, 2021

Make sure that you've checked the boxes below before you submit PR:

Always

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Written well with PR title, we generate the release notes base on that

For the bug fixes or features only

  • Quality Gate Passed. Change this URL to your PR.
  • The coverage is xxx on the new lines
  • I've tested it by manual in the following platform
    • MacOS
    • Linux
    • Windows
  • Unit Test covered
  • e2e Test covered

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #620 (ac35eda) into master (26b4f1f) will not change coverage.
The diff coverage is n/a.

❗ Current head ac35eda differs from pull request most recent head fa3cb40. Consider uploading reports for the commit fa3cb40 to get more accurate results

@@           Coverage Diff           @@
##           master     #620   +/-   ##
=======================================
  Coverage   37.98%   37.98%           
=======================================
  Files          13       13           
  Lines         416      416           
=======================================
  Hits          158      158           
  Misses        246      246           
  Partials       12       12           
Flag Coverage Δ
unittests 37.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b4f1f...fa3cb40. Read the comment docs.

@JohnNiang
Copy link
Member

Please confirm that the CI passed.

@LinuxSuRen
Copy link
Member

LinuxSuRen commented Aug 27, 2021

Please confirm that the CI passed.

The e2e tests might have some problems. I guess we can just forget it until we fixed it.

@JohnNiang you can help to review this PR.

@jxr98 jxr98 changed the title Add new feature to create yaml including jenkins core and plugins and give users a choice to choose WIP:Add new feature to create yaml including jenkins core and plugins and give users a choice to choose Aug 27, 2021
@jxr98 jxr98 changed the title WIP:Add new feature to create yaml including jenkins core and plugins and give users a choice to choose Add new feature to create yaml including jenkins core and plugins and give users a choice to choose Aug 28, 2021
@jxr98
Copy link
Contributor Author

jxr98 commented Aug 28, 2021

The center_list and plugin_center are also included in the other two prs, but I need to use some of the functions and struct type defined in those two files. Maybe we can review the other two prs first.

@LinuxSuRen
Copy link
Member

The center_list and plugin_center are also included in the other two prs, but I need to use some of the functions and struct type defined in those two files. Maybe we can review the other two prs first.

Can you point which two PRs?

@jxr98
Copy link
Contributor Author

jxr98 commented Sep 6, 2021

The center_list and plugin_center are also included in the other two prs, but I need to use some of the functions and struct type defined in those two files. Maybe we can review the other two prs first.

Can you point which two PRs?

One has been merged and the other is #611.

jxr98 and others added 12 commits September 12, 2021 10:46
…kins-zh#622)

* Bump github.com/linuxsuren/http-downloader from 0.0.29 to 0.0.33

Bumps [github.com/linuxsuren/http-downloader](https://github.com/linuxsuren/http-downloader) from 0.0.29 to 0.0.33.
- [Release notes](https://github.com/linuxsuren/http-downloader/releases)
- [Changelog](https://github.com/LinuxSuRen/http-downloader/blob/master/.goreleaser.yml)
- [Commits](LinuxSuRen/http-downloader@v0.0.29...v0.0.33)

---
updated-dependencies:
- dependency-name: github.com/linuxsuren/http-downloader
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Run go mod tidy

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rick <[email protected]>
@jxr98 jxr98 changed the title Add new feature to create yaml including jenkins core and plugins and give users a choice to choose WIP:Add new feature to create yaml including jenkins core and plugins and give users a choice to choose Sep 12, 2021
@jxr98
Copy link
Contributor Author

jxr98 commented Sep 28, 2021

Try this command ./jcli upgrade labmouse and a docker installed local or remotely with the Docker Daemon exposed with a port. The default is 127.0.0.1:2375. For example, if you have Docker available in 209.23.56.59 with the Docker Daemon exposed with -H tcp://0.0.0.0:8888, please add --ip 209.23.56.59 --docker-port 8888 to the command.
This command is going to prompt your choose what you want to upgrade and start jenkins with the upgraded and 'unupgraded' plugins in a docker container and conduct an API test.

@jxr98 jxr98 changed the title WIP:Add new feature to create yaml including jenkins core and plugins and give users a choice to choose Add new feature to create yaml including jenkins core and plugins and give users a choice to choose Sep 28, 2021
@LinuxSuRen LinuxSuRen merged commit 250691b into jenkins-zh:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants