Add new feature to backup jenkins relying on thinBackup plugin #638
Conversation
Update job_log.go Create docker_run.go Update docker_run.go Update docker_run.go Update docker_run.go Update docker_run.go Update docker_run.go Update job_log.go Update go.mod Update docker_run.go Update docker_run.go
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
=======================================
Coverage 37.98% 37.98%
=======================================
Files 13 13
Lines 416 416
=======================================
Hits 158 158
Misses 246 246
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
jxr98
force-pushed
the
backup
branch
3 times, most recently
from
a76928c to
148cb92
Compare
|
This function backs up global and job specific configurations relying on thinBackup plugin. I found an url which can trigger thinBackup to backup, but it doesn't return any message. Thus, jcli cannot handle errors which may happen and cannot make sure that the backup succeeded. I figured out a solution which is the --check flag. If jcli can access the backup directory set in thinBackup plugin, '--check true' is recommended to be parsed to backup command and then jcli will check if a new directory which follows a name pattern is created. |
jxr98
force-pushed
the
backup
branch
2 times, most recently
from
65088a1 to
35f7499
Compare
jxr98
changed the title
|
still working on this PR? |
I think it is done for now and I created a pull request in thinBackup plugin repository. The pr is waiting to be reviewed. Now this backup function can not check if backup succeeds in remote computer. |
WIP means working in progress |
jxr98
changed the title
Make sure that you've checked the boxes below before you submit PR:
Always
For the bug fixes or features only