Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ACE Editor #319

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Add support for ACE Editor #319

merged 1 commit into from
Feb 2, 2023

Conversation

basil
Copy link
Member

@basil basil commented Feb 1, 2023 •
edited
Loading

When consumed by jenkinsci/workflow-cps-plugin#654, fixes #127.

@basil basil mentioned this pull request Feb 1, 2023
Merged
@basil basil marked this pull request as ready for review February 1, 2023 18:58
@basil basil requested a review from a team as a code owner February 1, 2023 18:58
@NotMyFault NotMyFault added the enhancement New feature or request label Feb 2, 2023
NotMyFault
NotMyFault approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@NotMyFault NotMyFault merged commit b169690 into jenkinsci:master Feb 2, 2023
@basil basil mentioned this pull request Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jenkins Pipeline script edit page
2 participants
@basil @NotMyFault