Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-75321] Clarify the message displayed when loading the content of the build history widget #10309

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Feb 21, 2025

See JENKINS-75321.

This displays an explicit message about loading builds data instead of displaying "no builds".

Testing done

Recordings using a local patch increasing the delay by 2 seconds to make it more visible.

Details
Index: src/main/js/pages/project/builds-card.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/main/js/pages/project/builds-card.js b/src/main/js/pages/project/builds-card.js
--- a/src/main/js/pages/project/builds-card.js	(revision 5d65d117a52ce8494923f71c9a090c859812ec27)
+++ b/src/main/js/pages/project/builds-card.js	(date 1740144645635)
@@ -141,7 +141,7 @@
   load();
 }, 150);
 
-document.addEventListener("DOMContentLoaded", function () {
+document.addEventListener("DOMContentLoaded", async function () {
   pageSearchInput.addEventListener("input", function () {
     container.classList.add("app-builds-container--loading");
     pageSearch.classList.add("jenkins-search--loading");
@@ -149,6 +149,7 @@
   });
 
   container.classList.add("app-builds-container--loading");
+  await new Promise(r => setTimeout(r, 2000));
   load();
 
   window.addEventListener("focus", function () {

A project without any build

loading-no-builds.mov

A project with 2 builds

loading-2-builds.mov

Proposed changelog entries

  • Clarify the displayed message while the build history widget initializes.

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@Vlatombe Vlatombe requested a review from janfaracik February 21, 2025 13:36
@comment-ops-bot comment-ops-bot bot added the bug For changelog: Minor bug. Will be listed after features label Feb 21, 2025
@janfaracik
Copy link
Contributor

Hey, thanks! Tried it locally and looks good to me :)

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much. I had noticed the initial empty list of builds on ci.jenkins.io but did not have the presence of mind to report it as an issue.

@timja
Copy link
Member

timja commented Feb 22, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 22, 2025
@krisstern krisstern merged commit 9faff3e into jenkinsci:master Feb 24, 2025
17 checks passed
@Vlatombe Vlatombe deleted the JENKINS-75321-loading-builds branch February 24, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants