Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only limit height of console widget #10368

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PhilippHomann
Copy link
Contributor

@PhilippHomann PhilippHomann commented Mar 3, 2025

PR #10147 changed the layout of the build page.
Unfortunately the height of the Summary is limited to 300px after that commit and there is no scrollbar shown for summaries higher than that.
This commit just limits the height property to the console widget.
Alternatively a overflow: scroll could be added.
Maybe @janfaracik might leave a comment on whats more desired.

Testing done

Proposed changelog entries

  • Fix limitation of summary widget on build page

Proposed changelog category

/label regression-fix, web-ui

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@comment-ops-bot comment-ops-bot bot added web-ui The PR includes WebUI changes which may need special expertise regression-fix Pull request that fixes a regression in one of the previous Jenkins releases labels Mar 3, 2025
Copy link

I wasn't able to add the following labels: web-ui

Check that the label exists and is spelt right then try again.

@krisstern krisstern requested a review from janfaracik March 4, 2025 13:24
Copy link

I wasn't able to add the following labels: web-ui

Check that the label exists and is spelt right then try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-fix Pull request that fixes a regression in one of the previous Jenkins releases web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant