Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-57993] Avoid printing stack traces for some common agent conditions #4066

Merged
merged 2 commits into from
Jun 15, 2019
Merged

[JENKINS-57993] Avoid printing stack traces for some common agent conditions #4066

merged 2 commits into from
Jun 15, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 12, 2019 •
edited
Loading

See JENKINS-57993. In the spirit of jenkinsci/remoting#274 etc.

Proposed changelog entries

  • Converting some stack traces related to agent channels into simpler messages.

@jglick jglick requested a review from Vlatombe June 12, 2019 21:11
@jglick jglick mentioned this pull request Jun 12, 2019
Merged
@jglick jglick added the work-in-progress The PR is under active development, not ready to the final review label Jun 13, 2019
@jglick
Copy link
Member Author

jglick commented Jun 13, 2019

Downstream still occasionally fails with this race condition (as the agent is being deleted):

WARNING	h.n.AbstractAsyncNodeMonitorDescriptor#monitorDetailed: Failed to monitor runinpod-… for Clock Difference
java.nio.channels.ClosedChannelException
Caused: hudson.remoting.RequestAbortedException
	at hudson.remoting.Request.abort(Request.java:340)
	at hudson.remoting.Channel.terminate(Channel.java:1040)
	at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer.onReadClosed(ChannelApplicationLayer.java:209)
	at org.jenkinsci.remoting.protocol.ApplicationLayer.onRecvClosed(ApplicationLayer.java:222)
	at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.onRecvClosed(ProtocolStack.java:816)
	at org.jenkinsci.remoting.protocol.FilterLayer.onRecvClosed(FilterLayer.java:287)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.onRecvClosed(SSLEngineFilterLayer.java:181)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.switchToNoSecure(SSLEngineFilterLayer.java:283)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.processWrite(SSLEngineFilterLayer.java:503)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.processQueuedWrites(SSLEngineFilterLayer.java:248)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.doSend(SSLEngineFilterLayer.java:200)
	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.doCloseSend(SSLEngineFilterLayer.java:213)
	at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.doCloseSend(ProtocolStack.java:784)
	at org.jenkinsci.remoting.protocol.ApplicationLayer.doCloseWrite(ApplicationLayer.java:173)
	at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer$ByteBufferCommandTransport.closeWrite(ChannelApplicationLayer.java:314)
	at hudson.remoting.Channel.close(Channel.java:1452)
	at hudson.remoting.Channel.close(Channel.java:1405)
	at hudson.slaves.SlaveComputer.closeChannel(SlaveComputer.java:844)
	at hudson.slaves.SlaveComputer.access$800(SlaveComputer.java:105)
	at hudson.slaves.SlaveComputer$3.run(SlaveComputer.java:753)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused: java.util.concurrent.ExecutionException
	at hudson.remoting.Request$1.get(Request.java:319)
	at hudson.remoting.Request$1.get(Request.java:240)
	at hudson.remoting.FutureAdapter.get(FutureAdapter.java:59)
	at hudson.node_monitors.AbstractAsyncNodeMonitorDescriptor.monitorDetailed(AbstractAsyncNodeMonitorDescriptor.java:112)
	at hudson.node_monitors.AbstractAsyncNodeMonitorDescriptor.monitor(AbstractAsyncNodeMonitorDescriptor.java:76)
	at hudson.node_monitors.AbstractNodeMonitorDescriptor$Record.run(AbstractNodeMonitorDescriptor.java:303)

@jglick jglick removed the work-in-progress The PR is under active development, not ready to the final review label Jun 13, 2019
@jglick jglick requested review from Vlatombe and a team June 13, 2019 14:59
oleg-nenashev
oleg-nenashev approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, but would benefit from a review by @jeffret-b

@oleg-nenashev oleg-nenashev requested a review from jeffret-b June 13, 2019 20:34
@oleg-nenashev oleg-nenashev added the needs-more-reviews Complex change, which would benefit from more eyes label Jun 13, 2019
jeffret-b
jeffret-b approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@jeffret-b jeffret-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor. I've noticed there are quite a few messages that are more severe than justified. They show up under normal or harmless situations but confuse people and clutter logs. I've cleaned up some in various PRs. These ones look like good improvements also.

Wadeck
Wadeck approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 quick look, nothing seems wrong.

@jglick jglick added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed needs-more-reviews Complex change, which would benefit from more eyes labels Jun 14, 2019
@oleg-nenashev oleg-nenashev merged commit dcc395b into jenkinsci:master Jun 15, 2019
@jglick jglick deleted the quiet-JENKINS-57993 branch June 17, 2019 13:17
olivergondza pushed a commit that referenced this pull request Jul 1, 2019
@oleg-nenashev @olivergondza
Merge pull request #4066 from jglick/quiet-JENKINS-57993
f5099f9 
[JENKINS-57993] Avoid printing stack traces for some common agent conditions

(cherry picked from commit dcc395b)
@jglick jglick mentioned this pull request May 9, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvz jvz jvz approved these changes

@Wadeck Wadeck Wadeck approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@jeffret-b jeffret-b jeffret-b approved these changes

@Vlatombe Vlatombe Awaiting requested review from Vlatombe

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jglick @Vlatombe @jvz @Wadeck @oleg-nenashev @jeffret-b