-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IntelliJ/Java: Duplicate code -- Refactored as CreateJobHelper.setup #4078
Conversation
4673455
to
a84e993
Compare
@@ -0,0 +1,45 @@ | |||
package hudson.cli; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use another package for new classes. It is also not clear why a new class would be needed at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no particularly common class between the two existing classes. I'm happy to put it somewhere else. I just need advice.
I used a class because there were two things that were needed and I didn't have a particularly better way to provide both. I'm not used to returning multiple values in Java outside the form of a class. I'm open to suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oleg-nenashev: to be clear, since @daniel-beck thinks you missed it, I was asking you for advice. What package would you suggest?
How would you make a static helper class work?
I'll note that the merge conflicts for this were someone doing identical cleanup. Had this been merged, they would have only needed to perform the cleanup once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need in the new class is unclear. Also, automatic IntellijIDEA code generation does not look to be a good solution here. Non-static helper classes is a bad idea IMHO
@oleg-nenashev requested changes on Jul and there has been no activity since then. Besides, there are unresolved merge conflicts, so I'm proposing for close. @jsoref please, if you are still interested in this PR, let me know so I can remove the label |
Given there's been no response for nearly one month now, I'm closing this. Please feel free to reopen in case you consider working on this again. |
@fcojfernandez: the day after you added your commnet, I asked a question of @oleg-nenashev #4078 (comment). Nothing happened until @varyvol closed this. I was interested then, and I've pushed a merged commit here. -- which people can't see because I can't reopen this PR. |
This is for discussion.
Notes:
Proposed changelog entries
Internal:
Internal Java code cleanupSubmitter checklist
* Use the
Internal:
prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers
@Wadeck