IntelliJ/Java: Duplicate code -- Refactored as ExtensionFinder.getClassFromIndex #4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wadeck
approved these changes
Jun 19, 2019
There was a problem hiding this comment.
Thx for the split, lot easier to review the changes!
nitpick: as you modified the duplicate code, you can ensure consistency by putting { ... } around the last else statement (the one for throw new AssertionError();) (looking forward to have a better multiline suggestion feature from GH)
jsoref
force-pushed
the
extensionfinder-getclassfromindex
branch
from
14bd9f2 to
4e1fe91
Compare
jsoref
force-pushed
the
extensionfinder-getclassfromindex
branch
from
4e1fe91 to
e95fe1c
Compare
|
@Wadeck: added as a distinct commit because there are two places where that seems useful. |
oleg-nenashev
requested changes
Jun 27, 2019
jsoref
force-pushed
the
extensionfinder-getclassfromindex
branch
from
e95fe1c to
faff454
Compare
jsoref
commented
Jun 27, 2019
| @@ -758,5 +737,20 @@ private Level logLevel(IndexItem<Extension, Object> item) { | |||
| } | |||
| } | |||
|
|
|||
| private static Class<?> getClassFromIndex(IndexItem<Extension, Object> item) throws InstantiationException { | |||
There was a problem hiding this comment.
@oleg-nenashev: marked as private
jvz
approved these changes
Jun 27, 2019
jsoref
added a commit
to jsoref/jenkins
that referenced
this pull request
Jul 3, 2019
…ssFromIndex (jenkinsci#4079) * IntelliJ/Java: Duplicate code -- Refactored as ExtensionFinder.getClassFromIndex * Adding braces around throw new AssertionError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for discussion.
Notes:
Proposed changelog entries
Internal:Internal Java code cleanupSubmitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers
@Wadeck