Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntelliJ/Java: Duplicate code -> ChunkedInputStream.advanceChunk #4256

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Oct 3, 2019

Refactored as ChunkedInputStream.advanceChunk

This is for discussion.

Notes:

  • Most commits were created by IntelliJ
  • Individual commits are mostly self contained
  • In general, most commits should not change program behavior at all

This is generally a subset of https://github.com/jsoref/jenkins/commits/java-cleanup-full

Proposed changelog entries

  • Internal: Internal Java code cleanup

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

Refactored as ChunkedInputStream.advanceChunk
@jsoref jsoref mentioned this pull request Oct 3, 2019
4 tasks
@jsoref jsoref changed the title IntelliJ/Java: Duplicate code IntelliJ/Java: Duplicate code -> ChunkedInputStream.advanceChunk Oct 3, 2019
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to follow the standard Java codestyle, but LGTM functionally, wice.
Approving since the code is readable

I plan to merge it tomorrow if no negative feedback

@oleg-nenashev oleg-nenashev added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog labels Oct 11, 2019
@oleg-nenashev oleg-nenashev merged commit 368d1de into jenkinsci:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants