-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new Run#getBuildsOverThreshold() method for getting runs above the desired execution result #4259
Merged
oleg-nenashev
merged 3 commits into
jenkinsci:master
from
jsoref:java-cleanup-Run.getBuildsOverThreshold
Oct 22, 2019
Merged
Introduce new Run#getBuildsOverThreshold() method for getting runs above the desired execution result #4259
oleg-nenashev
merged 3 commits into
jenkinsci:master
from
jsoref:java-cleanup-Run.getBuildsOverThreshold
Oct 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored as Run.getBuildsOverThreshold
oleg-nenashev
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor comment
Co-Authored-By: Oleg Nenashev <[email protected]>
res0nance
reviewed
Oct 8, 2019
MRamonLeon
approved these changes
Oct 11, 2019
oleg-nenashev
approved these changes
Oct 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, ready to go?
I plan to merge it tomorrow if no negative feedback |
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
developer
Changes which impact plugin developers
plugin-api-changes
Changes the API of Jenkins available for use in plugins.
ready-for-merge
The PR is ready to go, and it will be merged soon if there is no negative feedback
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored as Run.getBuildsOverThreshold
This is for discussion.
Notes:
This is generally a subset of https://github.com/jsoref/jenkins/commits/java-cleanup-full
Proposed changelog entries
Internal:
Internal Java code cleanupSubmitter checklist
* Use the
Internal:
prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers