-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show plugin release date in plugin manager #4535
Show plugin release date in plugin manager #4535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a nice feature. Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #4535 (comment),
should be a minor fix hopefully
it was already there, although this makes it worse
It's due to ridiculously long version numbers like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether formatting would differ depending on the user locale, but it is fine even if it is not
It does, that's the whole point of using this control. |
Co-Authored-By: Oleg Nenashev <[email protected]>
if you see my screenshot it has a different locale to DB's |
- Sort independently of sortable.js date parsing magic - Hide categories when sorting by release date
…into plugin-release-date
This now depends on #4534 not being merged before this, or https://github.com/jenkinsci/jenkins/pull/4535/files#diff-6c89c5cced7eb382005a0b0825a45140R70 needs |
I considered that, but was unsure how this would impact sorting by this column. Given how useless sort by version is, I guess this column would then sort by release date? Is that useful UX? |
If we want to sort by release date, we would definitely need a column just for it IMO |
Well, the table is sortable. Right now it's possible to sort by name and version number (🤣). Sorting by date is potentially the most useful of any of them (even if there's no obvious use case other than something like getting general ecosystem status at a glance). Anyway, I like your "time span" idea a lot better than just displaying the date. I will implement that. The specific date can always be the tool tip. |
May I also suggest using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
Universal approval, so marking |
@daniel-beck are you able to resolve the conflicts please? |
*cough* #4535 (comment) *cough* 😁 |
Lol, other one had been updated more recently so it was higher in the list, and your comment got buried above many other comments :p |
This was one of the feedbacks at the contributor summit at FOSDEM: It would be helpful to see at a glance when a plugin was released, to help understand how actively it is maintained.
Up to date screenshots in #4535 (comment)
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate