Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.github.spotbugs:spotbugs-maven-plugin from 4.8.3.1 to 4.9.2.0 #1103

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Bump com.github.spotbugs:spotbugs-maven-plugin from 4.8.3.1 to 4.9.2.0 #1103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76b4bfd
Bump com.github.spotbugs:spotbugs-maven-plugin from 4.8.3.1 to 4.9.2.0
dependabot[bot] Mar 4, 2025
73f7dc2
Revise omitVisitors
basil Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 29 additions & 8 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,23 +105,44 @@
<maven-surefire-plugin.version>3.5.2</maven-surefire-plugin.version>
<maven-war-plugin.version>3.4.0</maven-war-plugin.version>
<mockito.version>5.16.0</mockito.version>
<spotbugs-maven-plugin.version>4.8.3.1</spotbugs-maven-plugin.version>
<spotbugs-maven-plugin.version>4.9.2.0</spotbugs-maven-plugin.version>
<spotless-maven-plugin.version>2.44.3</spotless-maven-plugin.version>
<stapler-maven-plugin.version>233.v9579d1a_8ea_28</stapler-maven-plugin.version>

<!-- Filled in by "maven-hpi-plugin" with the path to "org-netbeans-insane-hook.jar" extracted from "jenkins-test-harness" -->
<jenkins.insaneHook />

<!--
The MS_EXPOSE_REP, EI_EXPOSE_REP, EI_EXPOSE_REP2, EI_EXPOSE_STATIC_REP2, MS_EXPOSE_BUF,
EI_EXPOSE_BUF, EI_EXPOSE_STATIC_BUF2, and EI_EXPOSE_BUF2 bug patterns are noisy and create
little value; therefore, we suppress them globally.
The following bug patterns are noisy and create little value; therefore, we suppress them
globally.

The CT_CONSTRUCTOR_THROW bug pattern is related to libraries used with SecurityManager
and does not apply to Jenkins; we do not expect untrusted code to be running inside the
controller JVM, therefore we suppress it globally.
ConstructorThrow
CT_CONSTRUCTOR_THROW
FindReturnRef
EI_EXPOSE_BUF2
EI_EXPOSE_REP
EI_EXPOSE_REP2
EI_EXPOSE_STATIC_BUF2
EI_EXPOSE_STATIC_REP2
MS_EXPOSE_BUF
MS_EXPOSE_REP
MultipleInstantiationsOfSingletons
SING_SINGLETON_GETTER_NOT_SYNCHRONIZED
SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR
SING_SINGLETON_IMPLEMENTS_CLONEABLE
SING_SINGLETON_IMPLEMENTS_CLONE_METHOD
SING_SINGLETON_IMPLEMENTS_SERIALIZABLE
SING_SINGLETON_INDIRECTLY_IMPLEMENTS_CLONEABLE
SharedVariableAtomicityDetector
AT_NONATOMIC_64BIT_PRIMITIVE
AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE
AT_STALE_THREAD_WRITE_OF_PRIMITIVE
ThrowingExceptions
THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION
THROWS_METHOD_THROWS_CLAUSE_THROWABLE
THROWS_METHOD_THROWS_RUNTIMEEXCEPTION
-->
<spotbugs.omitVisitors>FindReturnRef,ConstructorThrow</spotbugs.omitVisitors>
<spotbugs.omitVisitors>ConstructorThrow,FindReturnRef,MultipleInstantiationsOfSingletons,SharedVariableAtomicityDetector,ThrowingExceptions</spotbugs.omitVisitors>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reference for what is driving the added exclusions? I am just aware of the @Nullable problem (#1063).


<!-- Set to false to enable Spotless -->
<spotless.check.skip>true</spotless.check.skip>
Expand Down