Cleanup hudson.remoting.Channel.Ref - NPE et al. #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an aggregated PR, cleans up the class implementation - [x] Fix the NPE risk introduced by @kohsuke in jenkinsci@0d8a2af - [x] Add name to toString() in order to display names for terminated channels - [x] Update Javadoc and annotations jenkinsci@0d8a2af also introduces the incompatible change of Ref#clear(), but it's fine this the class is package-internal
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
stephenc
approved these changes
Mar 6, 2017
|
@reviewbybees done |
jglick
reviewed
Mar 8, 2017
| @@ -1734,7 +1736,7 @@ public static void dumpDiagnosticsForAll(@Nonnull PrintWriter w) { | |||
| * @param channel the {@link Channel}. | |||
| */ | |||
| private Ref(@CheckForNull Channel channel) { | |||
| this.name = channel.getName(); | |||
| this.name = channel != null ? channel.getName() : "unknown (null reference)"; | |||
There was a problem hiding this comment.
FindBugs prints warnings, but it does not fail the build now. I am handling it as https://issues.jenkins-ci.org/browse/JENKINS-37566 . One year ago there were more than 100 failures, once I merge the pending PRs there should be only 10 left
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an aggregated PR, cleans up the class implementation
0d8a2af also introduces the incompatible change of Ref#clear(), but it's fine this the class is package-internal
@reviewbybees, esp. @stephenc as a creator of this class