Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA-1248] - Temporarily disable the Windows build till the INFRA issue is fixed #171

Closed

Conversation

oleg-nenashev
Copy link
Member

https://issues.jenkins-ci.org/browse/INFRA-1248, just a workaround

@reviewbybees @jtnord

@ghost
Copy link

ghost commented Jun 25, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the discussion in JIRA it is not clear what precisely you think the problem on CI is and what you expect the fix to be. My impression of the failure message is that it is a bug in the POM of this repository, so that should be fixed instead.

@jglick
Copy link
Member

jglick commented Jun 26, 2017

FTR

Failed to execute goal org.codehaus.mojo:build-helper-maven-plugin:1.7:regex-property (version-property) on project remoting: Execution version-property of goal org.codehaus.mojo:build-helper-maven-plugin:1.7:regex-property failed: Illegal group reference

@jglick
Copy link
Member

jglick commented Jun 26, 2017

<replacement>-SNAPSHOT (${build.type}-${now}-${user.name})</replacement>

Seems like build-helper-maven-plugin does not support a literalReplacement parameter, so we would either need to use some other plugin (Groovy, say), or patch that plugin, or drop this feature. Same for Jenkins core I suppose.

@jglick
Copy link
Member

jglick commented Jun 26, 2017

mvn -Duser.name='big$money' validate -e

produces

java.lang.IllegalArgumentException: Illegal group reference
	at java.util.regex.Matcher.appendReplacement(Matcher.java:857)
	at java.util.regex.Matcher.replaceAll(Matcher.java:955)
	at org.codehaus.mojo.buildhelper.RegexPropertyMojo.execute(RegexPropertyMojo.java:126)
	at …

@oleg-nenashev
Copy link
Member Author

Closing in favor of #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants