Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize to latest versions supported by Java 8 #340

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

sghill
Copy link
Contributor

@sghill sghill commented Jun 18, 2023

Upgrade POM parent and jenkins.version to last versions that support Java 8. Builds are enabled for Java 11 and 17.
Goal is to keep the build green and follow up with a subsequent PR to modernize to current recommended versions.

This has been done by the OpenRewrite recipes at sghill/rewrite-jenkins.

Testing done

Ran mvn clean verify.

Submitter checklist

Preview Give feedback

Fixes #337
Fixes #327
Related to #326
Fixes #322

- Requires Java 11
- Requires Jenkins 2.346.4
- Builds on Java 11 and 17
@sghill
Copy link
Contributor Author

sghill commented Jun 18, 2023

@scaytrase I think the build may only run with the Jenkinsfile on the target branch(?).

Java 11 is required and the included Jenkinsfile configuration is recommended starting with parent version 4.52.

@offa
Copy link
Contributor

offa commented Jul 28, 2023

@scaytrase I think the build may only run with the Jenkinsfile on the target branch(?).

Jenkinsfile changes require write access, otherwise they wont apply.

@sghill sghill changed the title Upgrade POM parent to 4.67 Modernize to latest versions supported by Java 8 Aug 6, 2023
@sghill
Copy link
Contributor Author

sghill commented Aug 6, 2023

@scaytrase based on offa's comment (thanks!) I've limited the scope of this PR to the latest versions that worked on Java 8 to keep the build green.

@sghill
Copy link
Contributor Author

sghill commented Aug 16, 2023

@scaytrase would you be interested in adding additional maintainers for this plugin?

@scaytrase
Copy link
Member

@sghill I'd like to, since I'm not using Jenkins for many years for now (but still like it). But I have no idea how to grand release permissions to maintainers. I can give only repo permissions here

@sghill
Copy link
Contributor Author

sghill commented Aug 16, 2023

@scaytrase I'm happy to help maintain. From Managing plugin permissions it sounds like there are two parts -

  1. Adding me to stashNotifier Developers team on GitHub
  2. Adding release permissions through repository-permissions-updater. I can submit a PR here adding myself if you'd like?

My goals for maintenance would be:

  1. Adopting automated plugin release to make maintenance easier. I've had a good CD experience on commons-text-api-plugin (enabled in cc850d17).
  2. Re-baselining every quarter to the minimum recommended Jenkins version with an automated PR like this one
  3. Staying current on tooling, which usually requires fixing SpotBugs issues and deprecations
  4. Minor operator improvements (additional logging for example)

For anything major happy to open a PR and leave it open for review/discussion for a week or so.

@scaytrase
Copy link
Member

Adding me to stashNotifier Developers team on GitHub

I have no permissions even for this one.

I can submit a PR here adding myself if you'd like?

I'd be happy if you can drive the whole process of maintenance sharing since I don't really know all the internal kitchen for Jenkisn development. Tag me wherever one need my approve for this, I'll come

@sghill
Copy link
Contributor Author

sghill commented Aug 16, 2023

Requested deploy permissions in jenkins-infra/repository-permissions-updater#3481

@scaytrase
Copy link
Member

I've given you permissions but rolled back since it says u've already given admin via team mebmership. thanks a lot!

@sghill
Copy link
Contributor Author

sghill commented Aug 16, 2023

Thanks @scaytrase!

@sghill sghill merged commit b37b1b7 into jenkinsci:release/1.x Aug 16, 2023
@sghill sghill deleted the modernize branch August 16, 2023 20:04
@sghill sghill added dependencies Pull requests that update a dependency file internal labels Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants