Add configuration class for custom adapters #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of supported adapters is hardcoded, which makes it difficult to use this gem on custom adapters. We use `postgresql_proxy` from `active_record_proxy_adapters`, for instance. Currently, we need to monkey patch the gem and hot swap the constant `HairTrigger::POSTGRESQL_ADAPTERS` when the application boots to make it work with the proxy adapter. Although it works, it's not ideal. I've added a new configuration class whose values will default to the current ones (`%i[mysql2 trilogy]` for `mysql_adapters`, `%i[postgresql postgis]` for `postgresql_adapters` , and `%i[sqlite litedb]` for `sqlite_adapters`), but allow the user to add custom adapters for each. I don't expect any breaking changes here as the values fall back to the existing constants.
|
@jenseng could you please review this when you have a chance? |
|
@jenseng bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of supported adapters is hardcoded, which makes it difficult to use this gem on custom adapters.
We use
postgresql_proxyfromactive_record_proxy_adapters, for instance. Currently, we need to monkey patch the gem and hot swap the constantHairTrigger::POSTGRESQL_ADAPTERSwhen the application boots to make it work with the proxy adapter.Although it works, it's not ideal.
I've added a new configuration class whose values will default to the current ones (
%i[mysql2 trilogy]formysql_adapters,%i[postgresql postgis]forpostgresql_adapters, and%i[sqlite litedb]forsqlite_adapters), but allow the user to add custom adapters for each.I don't expect any breaking changes here as the values fall back to the existing constants, but please double check. Thanks!