Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workerless #36

Merged
merged 15 commits into from
Dec 10, 2022
Merged

workerless #36

merged 15 commits into from
Dec 10, 2022

Conversation

jerch
Copy link
Owner

@jerch jerch commented Sep 17, 2022

WIP to get rid of the worker for sixels.

May close #7.

TODO:

@jerch
Copy link
Owner Author

jerch commented Sep 17, 2022

Now without worker:

  • sixel processing ~1.5x faster
  • latency got much better (making xtermdoom playable in firefox, too), also we now have quite instant cursor moves in jexer
  • downside: decoding happens in mainthread (eats precious main CPU), still it is streamlined, thus should not create perceivable blocking
  • 10 kB less on final packages
  • no more separate worker file (much easier to deal with on integrator side)

The workerless rework actually surfaced another issue - #37. Should be fixed before we merge the PR and do another release.

@jerch
Copy link
Owner Author

jerch commented Sep 18, 2022

#37 is still not fully fixed. It needs a more involved change in the decoder package (see #37 for details).

@pmp-p
Copy link

pmp-p commented Oct 6, 2022

is it available for testing ?

@jerch
Copy link
Owner Author

jerch commented Oct 6, 2022

@pmp-p
No not yet. Well you can build it from this PR, if you want (worker already gone).

#37 is currently blocking this PR, but I might do an independent release, if the fix gets too involving.

pmp-p added a commit to pygame-web/pygbag that referenced this pull request Oct 9, 2022
@jerch
Copy link
Owner Author

jerch commented Dec 10, 2022

Postponing #37, as the adjustments needed to get that properly working are quite involved (needs a fundamental patch in the underlying lib).

@jerch jerch marked this pull request as ready for review December 10, 2022 16:08
@jerch jerch merged commit d2c1fac into master Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make worker path optional
2 participants