Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve some helper methods #1282

Merged
merged 1 commit into from
May 13, 2024
Merged

Improve some helper methods #1282

merged 1 commit into from
May 13, 2024

Conversation

dfsmania
Copy link
Collaborator

Question Answer
Pull request type ENHANCEMENT
License MIT

What's in this PR?

Improve some helper methods:

  • Add better code style
  • Fix method descriptions
  • Add default values when reading config values

Checklist

  • I tested these changes.

@dfsmania dfsmania requested a review from resslinger May 13, 2024 15:34
@dfsmania dfsmania merged commit 29bfa31 into jeroennoten:master May 13, 2024
34 checks passed
@dfsmania dfsmania deleted the improve_some_helpers branch May 13, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resslinger resslinger resslinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfsmania @resslinger