Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(translate): Additional Chinese translation #3771

Closed

Conversation

iamxiaojianzheng
Copy link

@iamxiaojianzheng iamxiaojianzheng commented Jul 23, 2024

  • PR Description

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@iamxiaojianzheng iamxiaojianzheng changed the title doc(translate): Perfect Chinese translation doc(translate): Additional Chinese translation Jul 23, 2024
@stefanhaller
Copy link
Collaborator

@iamxiaojianzheng Thanks for the contribution! Unfortunately we can't use it, as the JSON file that you changed is machine-generated and shouldn't be edited manually. I just added a README file to the directory containing these files to make this clearer, hopefully (#3781).

We recently had another PR (#3766) that also changed the same file; in that case I took the JSON file and uploaded it to crowdin, so that the changes are not lost. I don't want to do the same thing again with your PR, as I'm worried about overwriting the changes from that other PR. This is not the workflow we want to use; please get an account at Crowdin and edit the translations there.

@iamxiaojianzheng
Copy link
Author

iamxiaojianzheng commented Jul 26, 2024

@iamxiaojianzheng Thanks for the contribution! Unfortunately we can't use it, as the JSON file that you changed is machine-generated and shouldn't be edited manually. I just added a README file to the directory containing these files to make this clearer, hopefully (#3781).

We recently had another PR (#3766) that also changed the same file; in that case I took the JSON file and uploaded it to crowdin, so that the changes are not lost. I don't want to do the same thing again with your PR, as I'm worried about overwriting the changes from that other PR. This is not the workflow we want to use; please get an account at Crowdin and edit the translations there.

Ok,I have completed most of the translations and hope to help those in need.

https://zh.crowdin.com/project/lazygit/zh-CN

@stefanhaller
Copy link
Collaborator

@iamxiaojianzheng Thank you very much! These will show up in lazygit the next time we update the JSON files from Crowdin, which will happen before the next release at the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants